IceTVDesc V1.0.6.7

grampus · Post by **grampus** » Thu Dec 24, 2020 12:28

I am confused reading the 4 options available.
My needs are to have the recorded file name have the season/info as the name with the hope it will be suitable for Tks.series to folder to have separate directories for the different seasons.
The prompt shown for the bottom option leaves me confused.
What options should I select to achieve my needs?

grampus · Post by **grampus** » Thu Dec 24, 2020 12:33

PS
I like the reset the EPG prompt
nice for a GOF like me to be told.

adoxa · Post by **adoxa** » Thu Dec 24, 2020 13:02

You want the last option ("Add season to title") for Series2Folder (Tks?) to use separate folders (it was my mistake it used the file name). This makes the season part of the name, so it's not e.g. "NCIS" which is "Season 18", it's "NCIS (Season 18)". That's why S2F will put it in separate directories, because it's now separate names. Because it's the name, that's also what will be used as the file name: ... - NCIS (Season 18).ts. However, because the previous option ("Add season/episode numbers to file name") will include the season already (assuming you're also using "Add season/episode numbers to short description"), I then remove it from the file name: ... - NCIS - S18E04.ts.

grampus · Post by **grampus** » Fri Dec 25, 2020 17:58

I’m finding a bit of a problem understanding that I’m afraid.
I wouldn’t mind if you could just tell me which options i need
to achieve the maximum result.
e.g.
actors, directors to the description
and have separate file names for season episode

eg 1, 2 on, 3 off,4 on.
then what is my next move?
allow epg reset
Do i need gui restart?

resend a new set of timers.

i would consider that maybe i need to remove all my series timers i have set up prior to all this,
then last move send down a new set of timers?

sorry for the churn.

Grumpy_Geoff · Post by **Grumpy_Geoff** » Fri Dec 25, 2020 18:38

Have them all on. Then disable/re-enable IceTV, then fetch the EPG (no need to resend timers, as the timer descriptions will automatically be updated).
Then you'd get as per this example, with the "season" added to the title, and "season/episode" added to the description and to the resultant recording file name.
Series2Folder should use the title from the recording's meta data and create a "title (season)" folder.

From the EPG -
Better Homes And Gardens (Season 17)
[Rpt] 2020 - Stylish Home Boat Accessible / Christmas Ham / Nimble - Record Holding Dog-Lete (S17E05)
Renovation, refurbishment or restoration of your home and everything inside and out. Craft, handyman hints, gardening savvy and even pet tips make for an entertaining and informative program, brought to you by a team of experts.

Year: 1996

The original IceTV entry -
Better Homes And Gardens
'2020 - Stylish Home Boat Accessible / Christmas Ham / Nimble - Record Holding Dog-Lete'
7TWO, 3:55pm, Fri, 25 Dec 2020, 30 minutes
REPEAT
Renovation, refurbishment or restoration of your home and everything inside and out. Craft, handyman hints, gardening savvy and even pet tips make for an entertaining and informative program, brought to you by a team of experts.
Series, Australia, English, Lifestyle, Season 17 Episode 5

Recording files (still currently recording) -

Code: Select all

root@beyonwizt4:/hdd/movie# ls -altr *Better*
-rw-r--r--    1 root     root           218 Dec 25 16:25 20201225 1550 - 7TWO Perth - Better Homes And Gardens - S17E05.ts.meta
-rw-r--r--    1 root     root           424 Dec 25 16:25 20201225 1550 - 7TWO Perth - Better Homes And Gardens - S17E05.eit
-rw-r--r--    1 root     root        160480 Dec 25 16:31 20201225 1550 - 7TWO Perth - Better Homes And Gardens - S17E05.ts.sc
-rw-r--r--    1 root     root     116277248 Dec 25 16:31 20201225 1550 - 7TWO Perth - Better Homes And Gardens - S17E05.ts
root@beyonwizt4:/hdd/movie#
root@beyonwizt4:/hdd/movie# cat *Better*.ts.meta
1:0:1:562:506:1013:EEEE0000:0:0:0::7TWO Perth
Better Homes And Gardens (Season 17)
[Rpt] 2020 - Stylish Home Boat Accessible / Christmas Ham / Nimble - Record Holding Dog-Lete (S17E05)
1608882600
Tuner-A
0
0
f:0
188
0
root@beyonwizt4:/hdd/movie#

grampus · Post by **grampus** » Fri Dec 25, 2020 18:49

grampus · Post by **grampus** » Fri Dec 25, 2020 20:42

I feel embarrassed to keep on it’s this.
But, my expectation was that after following the procedure., i would see file names with series/ep displayed when going into Media. but none of my new recordings showed any evidence of season/episode
on any of my recordings.

just for more complete information
S/w 9.3. 20201121 running on both U4 and T3
both upgraded by USB, and reconfigured from scratch.

I did have one occurrence of it working, when i was running ice TVDdesc V1.0.6.6
but removed and installed V1.0.6.7 when it appeared, due to the newer more complete info available, e.g “director”

Is there a switch that i need to configure maybe in the EPG config, that i need to look at, that i may be missing?
Looking at Recording and playback option
“composition of recording file names?
I have set at longfile names.

cheers.

Grumpy_Geoff · Post by **Grumpy_Geoff** » Fri Dec 25, 2020 21:10

grampus wrote: ↑
Fri Dec 25, 2020 20:42
I feel embarrassed to keep on it’s this.
But, my expectation was that after following the procedure., i would see file names with series/ep displayed when going into Media. but none of my new recordings showed any evidence of season/episode
on any of my recordings.

The media selection listing will show the titles as fetched from the EPG at recording time - so if the EPG event had a "(Season x)" in the title then that'd show in the media selection listing.
When that title has focus, the recording description (again as fetched at recording time) will have the "(SnnEnn)" season/episode annotation.

Here's the big take-away - the EPG contents drive most of this, and the contents are dependent on the IceTVDesc options, so every time you toggle an option you need to completely refresh the EPG.

grampus wrote: ↑
Fri Dec 25, 2020 20:42
Looking at Recording and playback option
“composition of recording file names?
I have set at longfile names.

I don't know if it works for the "Long filenames" setting, as perhaps they'll run out of permitted file name length.
What I showed you previously was "Standard".

grampus · Post by **grampus** » Fri Dec 25, 2020 21:44

tks again, i’ll have run at it tomorrow

prl · Post by **prl** » Sat Dec 26, 2020 11:43

Grumpy_Geoff wrote: ↑
Fri Dec 25, 2020 21:10

I don't know if it works for the "Long filenames" setting, as perhaps they'll run out of permitted file name length.

If there is a short description (IceTV subtitle), that is used in "Long filenames" setting. If there isn't a short description (e.g. for movies), then the long description is used. The long description can be up to ~4kB, so that could exceed the maximum 255-byte filename length, but that is handled (by truncating the filename before the extension with enough room to fit the longest extension) in Tools.Directories.getRecordingFilename().

There is also a limit of 4096 bytes on whole file paths (like /media/hdd/movie/recording_file_name), which isn't checked for when creating recordings, but should not normally be exceeded.

The file name length checking assumes that the actual maximum filename length is (at least) 255 bytes: it should probably be using sys.statvfs(recording_dest_dir).f_namemax instead.

The truncation of the filename also doesn't allow space for the "_NNN" filename prefix that is added when a recording is stopped and then restarted (e.g. buy a power failure of UI crash). If the filename is longer than 243 bytes (255 - len(".ts.meta") - len("_NNN")) and needs to have the sequence number added, that will probably cause the recording to fail (or perhaps a UI crash, depending on exactly what is done with the overly-long filename).

grampus · Post by **grampus** » Sun Dec 27, 2020 16:41

Wish i could have said tha.

But now seriously,
happy with the logic.
Setting a timer from EPG. Green button. gives me what i see as a desired result.
think i have to wait now for timers that haven’t bee sent to show a similar result.

Wait an see

Grumpy_Geoff · Post by **Grumpy_Geoff** » Sun Dec 27, 2020 17:07

grampus wrote: ↑
Sun Dec 27, 2020 16:41
Setting a timer from EPG. Green button. gives me what i see as a desired result.
think i have to wait now for timers that haven’t bee sent to show a similar result.

I think I may have given you a bum steer in regards to timers.
The timer description will be updated upon an EPG reload, but the scheduled IceTV timer name won't be as it comes in a request straight from IceTV and not via IceTVDesc's changes to the EPG contents - so a timer name won't change/be set to have "(Season n)".

If you're setting both "Add season/episode numbers to file name" and "Add season to title" options, then only "SnnEnn" will be added to the file name and "(Season n)" won't appear.
I think that if you're using only the "Add season to title" option, then this will only be added to a recording's file name for manual timers, because the file name is taken from the timer name and the manual timer name defaults to the EPG event title (which IceTVDesc has amended).

The recording name in the media selection list (left-hand pane) will show the name as set in the timer, but the details in the right-hand pane will show the updated title and description (from the {recording}.eit file I believe) as fetched from the EPG at the time of the recording. Thus any scheduled IceTV recording won't have "(Season n)" in its recording name, but should have it in its meta-data details.
I think.

grampus · Post by **grampus** » Mon Dec 28, 2020 13:11

After digesting all that, I think my results reflect what you say.
Pity, I would have liked to see the season being lifted from the detail, and becoming part of the file name.
FWIW, it’s till an improvement on was available prior to this feature.

Tks for the info.

adoxa · Post by **adoxa** » Mon Dec 28, 2020 14:38

grampus wrote: ↑
Mon Dec 28, 2020 13:11
Pity, I would have liked to see the season being lifted from the detail, and becoming part of the file name.

The file name should still be "... - NCIS - S18E04.ts" (assuming standard and the appropriate options). Do you just want the season number ("... - NCIS (Season 18).ts" or "... - NCIS - S18.ts"), or both ("... - NCIS (Season 18) - S18E04.ts"; this is what I normally don't do, since I regard it as redundant)?

Grumpy_Geoff · Post by **Grumpy_Geoff** » Mon Dec 28, 2020 14:54

adoxa wrote: ↑
Mon Dec 28, 2020 14:38
The file name should still be "... - NCIS - S18E04.ts" (assuming standard and the appropriate options).

Assuming the IceTV guide team don't encode more entries like they did with this one -
Death In Paradise
'Series 2, Part 7'
9Gem HD, 12:05pm, Mon, 28 Dec 2020, 70 minutes

adoxa · Post by **adoxa** » Mon Dec 28, 2020 15:06

Fixed (recognise "Episode" or "Part"), but I'll wait for grampus before posting.

grampus · Post by **grampus** » Mon Dec 28, 2020 15:38

I'm back.

grampus · Post by **grampus** » Mon Dec 28, 2020 16:32

looking back, you may be waiting for me to respond to the detail at the lower file level. (.ts.)

if that’s so, I only wish to see it all at a higher level
My druthers are that Series to folder will have a facility to pick up the season and episode as a name that it will recognise
to allow me to have my various favourite shows placed into directories for each series

I would hope that all this cane achieved from recordings that are created from IceTv downloads

adoxa · Post by **adoxa** » Mon Dec 28, 2020 17:00

grampus wrote: ↑
Mon Dec 28, 2020 16:32
looking back, you may be waiting for me to respond to the detail at the lower file level. (.ts.)

I was, yes (your avatar was apt

).

if that’s so, I only wish to see it all at a higher level

Ah, right. Since everything else is done via IceTVDesc it would probably be best if I also hook Series2Folder to do season directories, unless prl would like it to be done directly. I'm thinking something like "NCIS (Season 18)" would create directories "NCIS/Season 18"; if there's nothing in the title it could also look in the description: "NCIS" + "Episode Title (S18E04)" would also create "NCIS/Season 18". I'll actually be able to test this one, too.

grampus · Post by **grampus** » Mon Dec 28, 2020 17:18

I was, yes (your avatar was apt ).

ah yes, i’ve also been watching the cricket.

adoxa · Post by **adoxa** » Fri Jan 01, 2021 12:20

Here you go. There's a new option "Series to season folders" (only present if Series2Folder is installed) that should do what you want. You'll still want at least one of the other options on, though, for it to work properly (it still needs to get the season from either the title or description).

grampus · Post by **grampus** » Fri Jan 01, 2021 13:30

Great, thanks for the effort.
both U4 T3 updated.
hope to see results overnight.

Grumpy_Geoff · Post by **Grumpy_Geoff** » Fri Jan 01, 2021 14:18

adoxa wrote: ↑
Fri Jan 01, 2021 12:20
Here you go. There's a new option "Series to season folders" (only present if Series2Folder is installed) that should do what you want.

Uh oh, chongo -

Code: Select all

{661}<181433.721> Traceback (most recent call last):
{661}<181433.721>   File "/usr/lib/enigma2/python/Plugins/Extensions/Series2Folder/plugin.py", line 543, in runStep
{661}<181433.752>   File "/usr/lib/enigma2/python/Plugins/Extensions/Series2Folder/plugin.py", line 201, in addRecording
{661}<181433.753>   File "/usr/lib/enigma2/python/Plugins/Extensions/IceTVDesc/hook.py", line 37, in run
{661}<181433.761>   File "/usr/lib/enigma2/python/Plugins/Extensions/IceTVDesc/hook.py", line 172, in getShowInfo
{661}<181433.761> AttributeError: 'NoneType' object has no attribute 'startswith'
{661}<181433.762> [ePyObject] (CallObject(<bound method Series2FolderAutoActions.runStep of <Plugins.Extensions.Series2Folder.plugin.Series2FolderAutoActions object at 0x73e71410>>,()) failed)

adoxa wrote: ↑
Mon Dec 28, 2020 17:00
I'll actually be able to test this one, too.

prl · Post by **prl** » Fri Jan 01, 2021 14:56

It's hard to be sure without knowing what the data is that causes the problem, but that line in IceTVDesc's getShowInfo() will fail in that way if there is a substring like " (E1)" (where the "1" can be any non-empty digit string) at the end of the description.

I'd be inclined to make the RE something like:
r" $(?:S(\d+))(?:E\d+)?$$"
I don't think there's any reason to use lookahead here, as in the current code.

The RE I suggest will fail to match at all (and be handled correctly) in the current code environment on the description:
"The Greatest Show On Earth (E2)",
and will match the season in:
"The Greatest Show On Earth (S1E2)" and "The Greatest Show On Earth (S1)",

The current code will crash on the first one ("... (E2)"), because while the current RE will return a match, that match won't contain a match for group(1) (group(0) will be " (E2)").

prl · Post by **prl** » Fri Jan 01, 2021 15:09

BTW, if a season string "S0" ever appears, that will give a season "number" return of " ".

Perhaps:
if len(number) > 1 and number.startswith('0'):
instead of
if number.startswith('0'):

I'm not a fan of replacing the leading zero with a space, anyway, unless it's a requirement of the filename scrapers. It won't necessarily keep the season number to always be 2 characters (3- and 4-character season numbers are also used). It also doesn't handle strings of leading "0"s, like "001".

I'd be inclined to have something like:

Code: Select all

if number.startswith('0') and number != "0":
    number = number.lstrip(number, "0")

unless the space(s) must be there, when it gets a bit more complicated to do correctly (maybe needs an RE replacement).

paullings · Post by **paullings** » Fri Jan 01, 2021 16:02

I'm not sure what IceTV sends but in other programs I use, Infuse on Apple TV and Media Companion, Season 00 usually means it's a special so they recognize S00E01 as a special. The latest Call the Midwife Christmas special filename was called in IceTVDesc
20201226 1925 - ABC HD - Call The Midwife - S2019
however it should probably be S00Enn.

grampus · Post by **grampus** » Fri Jan 01, 2021 16:14

I assume it’s probably worth while removing the plug in.
just in case it has some detrimental effects.
Go back to a previous version (?) that will still give the more detailed descriptions.

or maybe i’ve missed the point completely.

adoxa · Post by **adoxa** » Fri Jan 01, 2021 16:29

Grumpy_Geoff wrote: ↑
Fri Jan 01, 2021 14:18
Uh oh, chongo -

Fixed (as prl says, the RE can be more specific in this case).

prl wrote: ↑
Fri Jan 01, 2021 15:09
BTW, if a season string "S0" ever appears, that will give a season "number" return of " ".

My code will only ever do "S00", and it's pretty unlikely " (S0)" would appear normally. But I probably should have fixed it anyway; next time.

I'm not a fan of replacing the leading zero with a space, anyway, unless it's a requirement of the filename scrapers.

It's so "Season 2" comes before "Season 10", and I find "Season 02" ugly in this context.

paullings wrote: ↑
Fri Jan 01, 2021 16:02
The latest Call the Midwife Christmas special filename was called in IceTVDesc
20201226 1925 - ABC HD - Call The Midwife - S2019
however it should probably be S00Enn.

IceTV would have sent the season as "2019" and no episode number, so that's what you get.

Grumpy_Geoff · Post by **Grumpy_Geoff** » Fri Jan 01, 2021 16:53

adoxa wrote: ↑
Fri Jan 01, 2021 16:29

Grumpy_Geoff wrote: ↑
Fri Jan 01, 2021 14:18
Uh oh, chongo -
Fixed (as prl says, the RE can be more specific in this case).

Confirmed.

prl · Post by **prl** » Fri Jan 01, 2021 17:14

adoxa wrote: ↑
Fri Jan 01, 2021 16:29

I'm not a fan of replacing the leading zero with a space, anyway, unless it's a requirement of the filename scrapers.
It's so "Season 2" comes before "Season 10", and I find "Season 02" ugly in this context.

Fair enough. I hadn't thought about sort order.

adoxa wrote: ↑
Fri Jan 01, 2021 16:29

paullings wrote: ↑
Fri Jan 01, 2021 16:02
The latest Call the Midwife Christmas special filename was called in IceTVDesc
20201226 1925 - ABC HD - Call The Midwife - S2019
however it should probably be S00Enn.
IceTV would have sent the season as "2019" and no episode number, so that's what you get.

This seems to be a variable feast. A recent Christmas special repeat was:
S07E01 <Call The Midwife> <Christmas Special 2017>

grampus · Post by **grampus** » Fri Jan 01, 2021 18:04

a question re installation if i may
procedure i have followed
remove distinguished plugin
Install new plugin
go to descriptor menu
turn off first option
press green
so no to renew epg.
then switch on first option
press green
say yes to renew epg

is there a need to restart the gui at any stage.?

adoxa · Post by **adoxa** » Fri Jan 01, 2021 18:22

grampus wrote: ↑
Fri Jan 01, 2021 18:04
is there a need to restart the gui at any stage.?

Shouldn't be - IceTVDesc reloads itself (you should see v1.0.7.1 in its title) and the fetch saves the EPG.

grampus · Post by **grampus** » Fri Jan 01, 2021 18:42

paullings · Post by **paullings** » Sat Jan 02, 2021 07:58

Thanks again Adoxa. Sub folders are working well for me.
Hopefully prl's approach to Daniel Hall will get consistency of data coming from IceTV.

prl · Post by **prl** » Sat Jan 02, 2021 08:19

paullings wrote: ↑
Sat Jan 02, 2021 07:58
Hopefully prl's approach to Daniel Hall will get consistency of data coming from IceTV.

I haven't heard back from Daniel. Maybe after the holidays.

grampus · Post by **grampus** » Sat Jan 02, 2021 08:35

Sub folders working
Tks

Paul_oz53 · Post by **Paul_oz53** » Sat Jan 02, 2021 10:59

grampus wrote: ↑
Sat Jan 02, 2021 08:35
Sub folders working
Tks

+1 Thanks Adoxa.

prl · Post by **prl** » Thu Jan 07, 2021 17:16

paullings wrote: ↑
Sat Jan 02, 2021 07:58
Hopefully prl's approach to Daniel Hall will get consistency of data coming from IceTV.

Daniel Hall has got back to me. He says that IceTV is currently doing a big data cleanup, and changing the textual Season/Episode data in subtitles to be consistently in the form "Series X, Episode X" is part of the cleanup.

Paul_oz53 · Post by **Paul_oz53** » Thu Jan 07, 2021 19:32

I notice an anomaly in the interaction between S2F and IceTV description 1.0.6.7 when dealing with the Big Bash.

The Main folder title becomes:

Code: Select all

Cricket_ Twenty

Not:

Code: Select all

Cricket_Twenty

I.E. A redundant space (or underscore) is present.

Not a biggy but a bit unsightly.

adoxa · Post by **adoxa** » Thu Jan 07, 2021 21:48

I suspect it should be Cricket_ Twenty_20 Big Bash, with the colon and slash being converted to underscore. It would appear the slash isn't converted, so I guess you've got a 20 Big Bash subdirectory. I did remove slash from the list of "bad" characters (so the subdirectory works), as I thought it was converted separately. ... Yeah, I don't see why it didn't work.

Paul_oz53 · Post by **Paul_oz53** » Thu Jan 07, 2021 22:48

adoxa wrote: ↑
Thu Jan 07, 2021 21:48
I suspect it should be Cricket_ Twenty_20 Big Bash, with the colon and slash being converted to underscore. It would appear the slash isn't converted, so I guess you've got a 20 Big Bash subdirectory. I did remove slash from the list of "bad" characters (so the subdirectory works), as I thought it was converted separately. ... Yeah, I don't see why it didn't work.

The slash not converting seems a likely explanation. Double underscore, double space or one space or underscore would all look better of course. The contracted name is weird and should be as you surmise but it doesn't offend me that it's missing text.

I do indeed have a

Code: Select all

20 Big Bash

subfolder. It does look odd but again, it doesn't faze me.

Please don't think I'm complaining about the plugin: that's not my intention. Its quite usable as it stands.

adoxa · Post by **adoxa** » Thu Jan 07, 2021 23:05

It should still be converting the slash to underscore, I'll look into it tomorrow.

If Windows compatibility isn't needed you could turn off "Use portable folder names" and keep the colon. Otherwise colon is replaced with underscore, so that's why it is what it is. What you want means either removing invalid characters altogether or replacing with space (I think this is what browsers do). Since I implement that function myself I could add another option...

Paul_oz53 · Post by **Paul_oz53** » Fri Jan 08, 2021 00:34

adoxa wrote: ↑
Thu Jan 07, 2021 23:05
It should still be converting the slash to underscore, I'll look into it tomorrow.

If Windows compatibility isn't needed you could turn off "Use portable folder names" and keep the colon. Otherwise colon is replaced with underscore, so that's why it is what it is. What you want means either removing invalid characters altogether or replacing with space (I think this is what browsers do). Since I implement that function myself I could add another option...

I'll give the suggestion to turn off portable filenames a whirl. I'll see what happens tonight.

adoxa · Post by **adoxa** » Fri Jan 08, 2021 11:00

adoxa wrote: ↑
Thu Jan 07, 2021 23:05
It should still be converting the slash to underscore, I'll look into it tomorrow.

Fixed (prl, you might want to fix it in S2F, too: showname = showname.replace('/', '_')).

prl · Post by **prl** » Fri Jan 08, 2021 11:14

Sounds like a good idea.

Paul_oz53 · Post by **Paul_oz53** » Sat Jan 09, 2021 12:59

Paul_oz53 wrote: ↑
Fri Jan 08, 2021 00:34

adoxa wrote: ↑
Thu Jan 07, 2021 23:05
It should still be converting the slash to underscore, I'll look into it tomorrow.

If Windows compatibility isn't needed you could turn off "Use portable folder names" and keep the colon. Otherwise colon is replaced with underscore, so that's why it is what it is. What you want means either removing invalid characters altogether or replacing with space (I think this is what browsers do). Since I implement that function myself I could add another option...

I'll give the suggestion to turn off portable filenames a whirl. I'll see what happens tonight.

Thanks Adoxa. Turning off portable filenames in S2F combined with the 1.0.7.2 update has fixed the quirkiness.

About the Forum

Join us