HelpMenu.py question...
HelpMenu.py question...
Hi Prl,
Is there a specific reason why the HelpMenu code in the showHelp() method specifically looks for the SecondInfoBarScreen and closes it if it is open? (This is also in OpenViX but not in OpenPLi.)
Regards,
Ian.
Is there a specific reason why the HelpMenu code in the showHelp() method specifically looks for the SecondInfoBarScreen and closes it if it is open? (This is also in OpenViX but not in OpenPLi.)
Regards,
Ian.
-
- Wizard God
- Posts: 32714
- Joined: Tue Sep 04, 2007 13:49
- Location: Canberra; Black Mountain Tower transmitters
Re: HelpMenu.py question...
I'm not sure. It was put there a long time ago and logged to Paul In & In in 2012 (I think that In & In did the original port of enigma2 to Beyonwiz). The code was originally:
Code: Select all
if self.secondInfoBarScreen and self.secondInfoBarScreen.shown:
self.secondInfoBarScreen.hide()
self.secondInfoBarWasShown = False
This was changed 12 days later by Paul In & In to:
Code: Select all
try:
if self.secondInfoBarScreen and self.secondInfoBarScreen.shown:
self.secondInfoBarScreen.hide()
except:
pass
I think that's longhand for "I don't know," but commenting the code out doesn't seem to do anything obviously bad.
Peter
T4 HDMI
U4, T4, T3, T2, V2 test/development machines
Sony BDV-9200W HT system
LG OLED55C9PTA 55" OLED TV
T4 HDMI
U4, T4, T3, T2, V2 test/development machines
Sony BDV-9200W HT system
LG OLED55C9PTA 55" OLED TV
Re: HelpMenu.py question...
Hi Prl,
That was my finding as well. I thought it better to ask.
I am preparing a port of your help improvements for use in OpenPLi and OpenViX. With all the extra help screens I am adding to their code they are starting to notice how poor was their original help system.
Regards,
Ian.
That was my finding as well. I thought it better to ask.
I am preparing a port of your help improvements for use in OpenPLi and OpenViX. With all the extra help screens I am adding to their code they are starting to notice how poor was their original help system.
Regards,
Ian.
-
- Wizard God
- Posts: 32714
- Joined: Tue Sep 04, 2007 13:49
- Location: Canberra; Black Mountain Tower transmitters
Re: HelpMenu.py question...
Yes, it was in pretty poor shape when I started work on it. It was probably little used because it wasn't all that good.
BTW, I think the code I wrote to do the button indicator movement animation in MovingPixmap is overcomplicated and should just use floating point arithmetic to calculate the intermediate points, and toss all the integer-only code that uses a modified Bresenham's line algorithm.
Peter
T4 HDMI
U4, T4, T3, T2, V2 test/development machines
Sony BDV-9200W HT system
LG OLED55C9PTA 55" OLED TV
T4 HDMI
U4, T4, T3, T2, V2 test/development machines
Sony BDV-9200W HT system
LG OLED55C9PTA 55" OLED TV
Re: HelpMenu.py question...
Hi Prl,
I would like this to go in with minimal change to minimise future merge issues. (VirtualKeyBoard.py and NumericalTextInput.py have been coded to be identical for all images.) If you want to tidy up the Beyonwiz version then I will simply track your improvements across the other images.
Regards,
Ian.
I would like this to go in with minimal change to minimise future merge issues. (VirtualKeyBoard.py and NumericalTextInput.py have been coded to be identical for all images.) If you want to tidy up the Beyonwiz version then I will simply track your improvements across the other images.
Regards,
Ian.
-
- Wizard God
- Posts: 32714
- Joined: Tue Sep 04, 2007 13:49
- Location: Canberra; Black Mountain Tower transmitters
Re: HelpMenu.py question...
OK, I'll have a look at it over the weekend.
Peter
T4 HDMI
U4, T4, T3, T2, V2 test/development machines
Sony BDV-9200W HT system
LG OLED55C9PTA 55" OLED TV
T4 HDMI
U4, T4, T3, T2, V2 test/development machines
Sony BDV-9200W HT system
LG OLED55C9PTA 55" OLED TV
Re: HelpMenu.py question...
Hi Prl,
If you want to really simplify the code you could leave out the animation. If I remember that was how it was previously. Either way, I will follow your lead.
Regards,
Ian.
If you want to really simplify the code you could leave out the animation. If I remember that was how it was previously. Either way, I will follow your lead.
Regards,
Ian.
-
- Wizard God
- Posts: 32714
- Joined: Tue Sep 04, 2007 13:49
- Location: Canberra; Black Mountain Tower transmitters
Re: HelpMenu.py question...
It's what's implementing the animation that's changing, not the use of animation in the Help screen. It's putting Components.PixMap.MovingPixmap back to closer to what it used to be.
Peter
T4 HDMI
U4, T4, T3, T2, V2 test/development machines
Sony BDV-9200W HT system
LG OLED55C9PTA 55" OLED TV
T4 HDMI
U4, T4, T3, T2, V2 test/development machines
Sony BDV-9200W HT system
LG OLED55C9PTA 55" OLED TV
-
- Wizard God
- Posts: 32714
- Joined: Tue Sep 04, 2007 13:49
- Location: Canberra; Black Mountain Tower transmitters
Re: HelpMenu.py question...
Submitted.prl wrote: ↑Fri Aug 24, 2018 12:56BTW, I think the code I wrote to do the button indicator movement animation in MovingPixmap is overcomplicated and should just use floating point arithmetic to calculate the intermediate points, and toss all the integer-only code that uses a modified Bresenham's line algorithm.
Peter
T4 HDMI
U4, T4, T3, T2, V2 test/development machines
Sony BDV-9200W HT system
LG OLED55C9PTA 55" OLED TV
T4 HDMI
U4, T4, T3, T2, V2 test/development machines
Sony BDV-9200W HT system
LG OLED55C9PTA 55" OLED TV
-
- Wizard God
- Posts: 32714
- Joined: Tue Sep 04, 2007 13:49
- Location: Canberra; Black Mountain Tower transmitters
Re: HelpMenu.py question...
prl wrote: ↑Sat Aug 25, 2018 14:48Submitted.prl wrote: ↑Fri Aug 24, 2018 12:56BTW, I think the code I wrote to do the button indicator movement animation in MovingPixmap is overcomplicated and should just use floating point arithmetic to calculate the intermediate points, and toss all the integer-only code that uses a modified Bresenham's line algorithm.
Merged and in firmware 20180825.
Peter
T4 HDMI
U4, T4, T3, T2, V2 test/development machines
Sony BDV-9200W HT system
LG OLED55C9PTA 55" OLED TV
T4 HDMI
U4, T4, T3, T2, V2 test/development machines
Sony BDV-9200W HT system
LG OLED55C9PTA 55" OLED TV